feat(outputs.influxdb_v2): Add rate limit implementation #15742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
srebhan
added
the
plugin/output
powersj
reviewed
Aug 16, 2024
There was a problem hiding this comment.
@srebhan - this is a great piece of work. Clearly this needs to be broken up into a variety of PRs to make reviewing easier, however, it accomplishes the goal nicely. I love that you were able to make the size + period config option work.
From the performance side, this nicely appears to have no affect on other existing use cases or if it no set.
I would have you consider working with support to have someone there test this out as well.
|
Thanks @powersj for your review. I'll adapt the spec then to reflect the possibility to set byte-based rate limits. I'll also break down the PR as it includes at least
Thanks again for the review! |
srebhan
changed the title
srebhan
changed the title
srebhan
changed the title
srebhan
changed the title
srebhan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the basic infrastructure to add rate-limiting to output plugins. As an example it converts the InfluxDBv2 plugin to the new infrastructure.
Checklist
Related issues
resolves #tbd